gnupic@linuxhacker.org
On Fri, Oct 24, 2003 at 12:28:41PM +0200, Gabor Kiss [Bitman] wrote:
> I'm proud to announce, that the first alpha version of 'Pista'
> (a PICSTART Plus handler utility) is available at
> ftp://gatling.ikk.sztaki.hu/pub/pic/pista/
Some comments for you.
a) most source kits are shipped as .tar.gz rather than .tgz, and if
you're accepting votes then I vote for .tar.gz
b) the .tgz file unpacks to the current directory without creating one,
mixing the files with what I have already at my current directory,
please change it to place all files in a new directory. I can explain
how to do that if you need to know.
c) there's no copyright or license. Before I use it, I want to know
what I can do with it. Would you like to adopt the GPL? Place a file
called COPYING that contains the GPL, and follow the instructions in it.
d) reviewed the code, looks neat, very few obvious defects, well done.
Some minor corrections are attached as a patch.
It might be an idea to adapt picprg or other command line parallel port
programmers to this model, so that we have a set of programmers to build
into a GUI.
I don't have a PICSTART myself, so I couldn't test it. I met someone on
a computer camp last month who was asking if I knew about "drivers for
using PICSTART on Linux", so now I can tell him I've seen one!
--
James Cameron mailto:quozl@us.netrek.org http://quozl.netrek.org/
--- pista.orig 2003-10-24 20:57:33.000000000 +1000
+++ pista 2003-10-24 21:03:39.000000000 +1000
@@ -98,7 +98,7 @@
sub cmd_bang {
print "140-Running external command\n".
- "140 Don't forget to chop a dot from line beninning\n";
+ "140 Don't forget to chop a dot from line beginning\n";
if (!open(CMD,"$_[0]|")) {
print "574 Cannot run external command: $!\n";
return;
--- ./Pista/Object/Pic.pm.orig 2003-10-24 21:16:06.000000000 +1000
+++ ./Pista/Object/Pic.pm 2003-10-24 21:16:38.000000000 +1000
@@ -110,7 +110,7 @@
print "133 Done\n";
}
else {
- print "134 Calib address is out of range\n";
+ print "134 Calibration address is out of range\n";
}
}
if (exists $range->{devid}) {
--- ./Pista/Programmer/PicStart.pm.orig 2003-10-24 21:10:59.000000000 +1000
+++ ./Pista/Programmer/PicStart.pm 2003-10-24 21:13:06.000000000 +1000
@@ -377,7 +377,7 @@
sub _read {
my ($self, $rdcmd, $start, $end, $width) = @_;
if ($start > $end) {
- die "gebasz\n";
+ die "Internal program error, start after end on _read";
}
my $status;
my $len = $end - $start + 1;
@@ -412,7 +412,7 @@
sub _write {
my ($self, $wrcmd, $start, $end, $width, $values) = @_;
if ($start > $end) {
- die "Internal program error";
+ die "Internal program error, start after end on _write";
}
my $status;
my $errors = 0;