nanogui@linuxhacker.org

Subject: [patch] devimage.c one-liner
From: Jamie Guinan
Date: Mon, 11 Sep 2000 09:31:20 -0400 (EDT)


In src/engine/devimage.c:GdLoadImageFromFile(), pimage->transcolor 
is left unitialized, and only LoadGIF() sets it properly.
LoadJPEG() and LoadBMP() do not set it.

This can trigger a segfault in src/engine/devdraw.c:GdDrawImage(), 
where transcolor is used to index the array convtable[].

CVS seems to be down this morning, patch against my most recent
copy follows.

Thanks,
-Jamie


--- src/engine/devimage.c.ori	Mon Sep 11 09:10:47 2000
+++ src/engine/devimage.c	Mon Sep 11 09:11:07 2000
@@ -77,6 +77,7 @@
 	}
 	pimage->imagebits = NULL;
 	pimage->palette = NULL;
+	pimage->transcolor = -1;
 
 #if defined(HAVE_BMP_SUPPORT)
 	if (loadOK == 0)