nanogui: Thread: PCF font render regression?


[<<] [<] Page 1 of 1 [>] [>>]
Subject: PCF font render regression?
From: Daniel ####@####.####
Date: 30 Apr 2010 14:46:40 -0000
Message-Id: <p2vd08fc9ca1004300746g2e441adez357a5c67f337b574@mail.gmail.com>

What's happened to PCF font rendering? There's no space between digits
and the space character is fully ignored. Attaching two images where
"pcfok.png" is showing old nano-X (latest prior moving to Git) and
"pcffail.png" shows the current version from Git.

The font is "HelvB12.pcf".

Regards
Daniel


Subject: Re: [nanogui] PCF font render regression?
From: "Greg Haerr" ####@####.####
Date: 30 Apr 2010 15:51:09 -0000
Message-Id: <00cb01cae87d$38320a40$0300a8c0@RDP>

: What's happened to PCF font rendering? There's no space between digits
: and the space character is fully ignored. Attaching two images where
: "pcfok.png" is showing old nano-X (latest prior moving to Git) and
: "pcffail.png" shows the current version from Git.

I have made some changes to font_pcf.c over the last several months,
trying to perfect output from NXLIB for FLTK, where funnily enough,
I had the exact problem with the space character.  The fix entailed
ADDING width to the space character.

Are you using GrText to output these strings all at once?
Perhaps you should post this program as well, (I know it 
looks quite simple!)

The area that I modified in font_pcf includes:

/* HACK: adjust width of SPACE char when == 1 large (use 'e') for now*/ 
if (i == ' ' && gwidth[n] <= 1) 
n += 'e'-' ';

Try commenting that out.  I will have to look into the other issues,

I'm not sure what the problem is yet.  Do you happen

to have a version of font_pcf.c that works you could send me?

Regards,

Greg

Subject: Re: [nanogui] PCF font render regression?
From: Daniel ####@####.####
Date: 3 May 2010 15:34:40 -0000
Message-Id: <v2id08fc9ca1005030833u47abc286q76e6c4a418c7d8d4@mail.gmail.com>

2010/4/30 Greg Haerr ####@####.####
> : What's happened to PCF font rendering? There's no space between digits
> : and the space character is fully ignored. Attaching two images where
> : "pcfok.png" is showing old nano-X (latest prior moving to Git) and
> : "pcffail.png" shows the current version from Git.
>
> I have made some changes to font_pcf.c over the last several months,
> trying to perfect output from NXLIB for FLTK, where funnily enough,
> I had the exact problem with the space character.  The fix entailed
> ADDING width to the space character.
>
> Are you using GrText to output these strings all at once?
> Perhaps you should post this program as well, (I know it
> looks quite simple!)
>
> The area that I modified in font_pcf includes:
>
> /* HACK: adjust width of SPACE char when == 1 large (use 'e') for now*/
> if (i == ' ' && gwidth[n] <= 1)
> n += 'e'-' ';
>
> Try commenting that out.  I will have to look into the other issues,
> I'm not sure what the problem is yet.  Do you happen
> to have a version of font_pcf.c that works you could send me?

My quick fix was to checkout font_pcf.c prior this years
modifications, which now works perfectly (== looks exactly as
earlier). If I get some time tomorrow I'll try with some of the
editions between the old one and the current one in git repo.

Regards
Daniel
Subject: Re: [nanogui] PCF font render regression?
From: Daniel ####@####.####
Date: 3 May 2010 15:38:17 -0000
Message-Id: <g2id08fc9ca1005030837h2c71a073p5d4cf70b708edf83@mail.gmail.com>

2010/4/30 Greg Haerr ####@####.####
> : What's happened to PCF font rendering? There's no space between digits
> : and the space character is fully ignored. Attaching two images where
> : "pcfok.png" is showing old nano-X (latest prior moving to Git) and
> : "pcffail.png" shows the current version from Git.
>
> I have made some changes to font_pcf.c over the last several months,
> trying to perfect output from NXLIB for FLTK, where funnily enough,
> I had the exact problem with the space character.  The fix entailed
> ADDING width to the space character.
>
> Are you using GrText to output these strings all at once?
> Perhaps you should post this program as well, (I know it
> looks quite simple!)
>
> The area that I modified in font_pcf includes:
>
> /* HACK: adjust width of SPACE char when == 1 large (use 'e') for now*/
> if (i == ' ' && gwidth[n] <= 1)
> n += 'e'-' ';
>
> Try commenting that out.  I will have to look into the other issues,
> I'm not sure what the problem is yet.  Do you happen
> to have a version of font_pcf.c that works you could send me?

My quick fix was to checkout font_pcf.c prior this years
modifications, which now works perfectly (== looks exactly as
earlier). If I get some time tomorrow I'll try with some of the
editions between the old one and the current one in git repo.

Regards
Daniel
Subject: Re: [nanogui] PCF font render regression?
From: "Greg Haerr" ####@####.####
Date: 3 May 2010 17:02:27 -0000
Message-Id: <022201caeae2$678999e0$6564a8c0@winXP>

> The area that I modified in font_pcf includes:
>
> /* HACK: adjust width of SPACE char when == 1 large (use 'e') for now*/
> if (i == ' ' && gwidth[n] <= 1)
> n += 'e'-' ';
>
> Try commenting that out. I will have to look into the other issues,
> I'm not sure what the problem is yet. Do you happen
> to have a version of font_pcf.c that works you could send me?

> My quick fix was to checkout font_pcf.c prior this years
modifications, which now works perfectly (== looks exactly as
earlier). If I get some time tomorrow I'll try with some of the
editions between the old one and the current one in git repo.


Daniel - 

I'm leaving for a week flight training, so I won't be able to
test for you this week.  If you could send a diff, or
also comment out the above code as suggested, I
can help figure this out.  Also, are you outputing 
all text with a single GrText, or differently?  Perhaps
I can get your sample text program.

Regards,

Greg
Subject: Re: [nanogui] PCF font render regression?
From: Daniel ####@####.####
Date: 4 May 2010 08:18:30 -0000
Message-Id: <u2ld08fc9ca1005040118l4012192ey383b87d3372af49e@mail.gmail.com>

Den 3 maj 2010 19.02 skrev Greg Haerr ####@####.####
>> The area that I modified in font_pcf includes:
>>
>> /* HACK: adjust width of SPACE char when == 1 large (use 'e') for now*/
>> if (i == ' ' && gwidth[n] <= 1)
>> n += 'e'-' ';
>>
>> Try commenting that out. I will have to look into the other issues,
>> I'm not sure what the problem is yet. Do you happen
>> to have a version of font_pcf.c that works you could send me?
>>
>> My quick fix was to checkout font_pcf.c prior this years
>> modifications, which now works perfectly (== looks exactly as
>> earlier). If I get some time tomorrow I'll try with some of the
>> editions between the old one and the current one in git repo.
>
>
> Daniel -
>
> I'm leaving for a week flight training, so I won't be able to
> test for you this week.  If you could send a diff, or
> also comment out the above code as suggested, I
> can help figure this out.  Also, are you outputing
> all text with a single GrText, or differently?  Perhaps
> I can get your sample text program.

Yes all text goes through one single GrText. I'll try to see if some
of the 2010 years changes works, else the diff is everything done this
year. You get it by: git diff 838b99 src/engine/font_pcf.c

Btw, just did a pull on master; "39 files changed, 1801 insertions(+),
255 deletions(-)". It seems you really put a lot of work to this
project. Thats great, and I hope nano-X gain some interests when 0.92
is released. Maybe you should announce the release to any of the
magazine which covered the project earlier (linuxfordevices et al).

Great luck with your flight week!

Regards
Daniel
[<<] [<] Page 1 of 1 [>] [>>]


Powered by ezmlm-browse 0.20.