nanogui: GrDrawImageToFit fail with PNG image with alpha layer
Subject:
Re: [nanogui] Re: GrDrawImageToFit fail with PNG image with alpha layer
From:
"Aaron J. Grier" ####@####.####
Date:
3 Jun 2010 22:57:32 -0000
Message-Id: <20100603225721.GQ1020@arwen.poofy.goof.com>
On Thu, Jun 03, 2010 at 08:13:32PM +0200, Daniel Nyström wrote:
> 2010/6/3 Aaron J. Grier ####@####.####
> > On Thu, Jun 03, 2010 at 03:00:57PM +0200, Daniel Nyström wrote:
> >> > assert (c < psd->ncolors);
> >
> > the assertion is incorrect for non-palettized video modes. I would just
> > remove the asserts, or change it to
> >
> > assert(psd->pixtype != MWPF_PALETTE || c < psd->ncolors)
>
> Since fblin24.c is specifically for 24bit RGB I guess pixtype will
> never be anything but MWPF_TRUECOLOR888, so just removing the assert
> would do?
that's what I figured and why I simply removed the assert. as to what
should be commit back to the trunk, I defer to Greg's judgement.
--
Aaron J. Grier | "Not your ordinary poofy goof." | ####@####.####
