nanogui: Image size limit?
Subject:
RE: [nanogui] RE: Image size limit?
From:
"Martin Kajdas" ####@####.####
Date:
17 Jul 2006 22:06:27 +0100
Message-Id: <CF2BB830A62F914F848E5AD5FFF57AC2291534@mkmail.MKPROD.COM>
I agree that the server should not crash and do something reasonable.
I did not look at other routines but everywhere there is a memcpy call,
it should be investigated if similar fix is required.
Some calls already have that, this is how I got my fix, but not all.
Martin
-----Original Message-----
From: Greg Haerr ####@####.####
Sent: Friday, July 14, 2006 6:29 PM
To: Martin Kajdas; ####@####.####
Subject: Re: [nanogui] RE: Image size limit?
> I fixed the GrBitmap to send data in chunks and it works. The problem is
fixed.
Woohoo!
> This made sense to me once I understood the limitations of the transfer
routines and that some pieces of code do not break up the transfers.
Martin, thanks for the code fix. This was definitely an oversight. I
thought I had all cases where variable length data was sent, handled.
What other routines did you see that might require fixing also?
Another thought is: perhaps the server should check that no
request is sent with a length value > MAXREQUESTSZ. In
this way, it wouldn't just crash, but could drop the request.
I need to look at the code to see why this isn't already handled
properly, that was the reason for the length word in the first
place - the packet should at least have been read properly
from the client request socket.
Regards,
Greg
