nanogui: Confused by hack


Previous by date: 4 Jan 2000 17:38:50 -0000 Re: SetBackground/GetBackground, Greg Haerr
Next by date: 4 Jan 2000 17:38:50 -0000 Re: SetBackground/GetBackground, Darran D. Rimron
Previous in thread:
Next in thread: 4 Jan 2000 17:38:50 -0000 Re: Confused by hack, Morten Rolland

Subject: Confused by hack
From: Greg Haerr ####@####.####
Date: 4 Jan 2000 17:38:50 -0000
Message-Id: <C1962B36D9BBD311B0F80060083DFEFBEFED@NBA-SLAM.CenSoft.COM>

: Index: engine/devdraw.c
: ===================================================================
: RCS file: /sw/CVSROOT/freepad/microwin/src/engine/devdraw.c,v
: retrieving revision 1.1.1.1
: diff -u -4 -r1.1.1.1 devdraw.c
: --- engine/devdraw.c    1999/12/20 09:19:14     1.1.1.1
: +++ engine/devdraw.c    2000/01/04 12:27:24
: @@ -1296,9 +1296,9 @@
:                 /*
:                  * For size considerations, there's no low-level area
:                  * draw, so we've got to draw everything with per-point
:                  * clipping for the time being
: -               if(pixtype != PF_PIXELVAL)
: +               if(pixtype != PF_PIXELVAL && pixtype != PF_TRUECOLOR565)
:                         break;
:                 psd->DrawArea(psd, x, y, width, height, pixels);
:                 GdFixCursor();
:                 return;

: The first patch to devdraw.c is a hack; it made it possible to use
: PF_TRUECOLOR565 on the client side, which should work when the server
: usese the same format natively.  This test should really look quite
: different and be dependent on the SCREEN_PIXTYPE macro instead (nanox
: server compile time option), but I have not tested this.

Morten - I'm a little confused by this "hack", since it's totally inside a
comment.
The screen driver doesn't currently implement a DrawArea method, so it's
completely commented out.  So what do you mean by "made it possible
to use PF_TRUECOLOR565 on the client side"?

Greg

Previous by date: 4 Jan 2000 17:38:50 -0000 Re: SetBackground/GetBackground, Greg Haerr
Next by date: 4 Jan 2000 17:38:50 -0000 Re: SetBackground/GetBackground, Darran D. Rimron
Previous in thread:
Next in thread: 4 Jan 2000 17:38:50 -0000 Re: Confused by hack, Morten Rolland


Powered by ezmlm-browse 0.20.