nanogui: pixmap buffer patch!
Subject:
Re: pixmap buffer patch!
From:
Alex Holden ####@####.####
Date:
27 Aug 2002 06:43:43 -0000
Message-Id: <3D6B1F8A.8030307@linuxhacker.org>
wang wrote:
> In the accessory is a patch to implement a single
> pixmap buffer,the buffer is dynamical,if it isn't be
> use for a while ,it can be released ,and if you don't
> use GrMoveWindow(),it will never be created .after
> using it ,the improvement on dragging agility is obvious,
> and I'm sure it won't waste any memory .
> Any comments is welcome!
* As I mentioned before, the hardest problem to solve cleanly with this,
and which you don't seem to have attempted to solve, is the problem of
what to do if something draws to the window that you are currently
dragging. You need to either throw away the buffer or draw to both the
buffer and the window (the former is probably easier).
* Please use the generic timer code (GdAddTimer()) rather than doing the
timing yourself.
* There's a memory leak- when someone drags a window and a buffer
already exists for a different window, a pixmap for the new window is
created and the old one is forgotten instead of being destroyed.
* Don't hard code timing values like that, make it a #define in some
central location with a comment explaining what it is.
--
------------ Alex Holden - http://www.linuxhacker.org ------------
If it doesn't work, you're not hitting it with a big enough hammer
