nanogui: Re: Memory leak in GrSendClientData
Subject:
Re: [nanogui] Re: Memory leak in GrSendClientData
From:
Alain Volmat ####@####.####
Date:
13 Jun 2005 06:04:24 +0100
Message-Id: <20050613050417.GA5007@pop.mail.yahoo.com>
As far as the GrSendClientData memory leak problem is concerned,
it is actually already inside the patch_092 directory.
Please check:
20040731-Possible_bug_in_GrSendClientData.txt
For the thislen vs len story .. I'll post the previous message on the FTP.
Alain
* Greg Haerr [Sun, 12 Jun 2005 at 20:51 -0600]
<quote>
> : We exchanged emails about a memory leak problem in GrSenClientData() a
> : while back. I notice there is now renewed activity in the nanox group. I
> : was wondering if this bug made it onto the offical bug list?
>
> No - it didn't. I rechecked, and nanox/srvfunc.c::GrSendClientData
> should just be:
>
> SERVER_LOCK();
> GsDeliverClientDataEvent(did, wid, serial, len, thislen, data);
> SERVER_UNLOCK();
>
> : >> Plus, I just noticed, in GrSendClient() memory of size 'len' is
> : >> malloc'ed for p>b But, 'thislen' is used for the size of the memcpy.
> : >> Shouldn't the malloc of 'p' be sized to 'thislen'?
>
> I further checked into the thislen vs len parameter: this API
> is extremely confusing. It was contributed, and I didn't check
> it carefully. The nanox/client.c code doesn't even look at the
> thislen param. So user API use of this function must effectively
> use len == thislen, FYI.
>
> Alain - can you please post this message to the 0.92 patches
> dir?
>
> Regards,
>
> Greg
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: ####@####.####
> For additional commands, e-mail: ####@####.####
>
</quote>
___________________________________________________________________________
Appel audio GRATUIT partout dans le monde avec le nouveau Yahoo! Messenger
Téléchargez cette version sur http://fr.messenger.yahoo.com
