nanogui: Thread: null keyboard prototype error

All,

I am using microwindows-0.89pre8 on an Embedded Planet 823 platform.
We were having trouble getting microwindows to run on the EP but in our
trials we found a prototype in kdb_null.c which read:
  static int  NUL_Read(MWUCHAR *buf, MWKEYMOD *modifiers, MWSCANCODE
*scancode);
when it should be:
  static int  NUL_Read(MWKEY *buf, MWKEYMOD *modifiers, MWSCANCODE
*scancode);

After changing this the microwindows build went through properly. Should
this be
updated in the microwindows source?

Regards,
     Michael Pergola
     Software Engineer
     Danfoss Air-Conditioning & Refrigeration Division
     7941 Corporate Blvd.
     Baltimore, MD  21236     (410) 931-6778 x4259

> Should this be updated in the microwindows source?

Yep... :)

Could you send a quick patch and CC ####@####.####  

Jordan

On Thursday 10 January 2002 08:18, Pergola, Michael mentioned:
> All,
>
> I am using microwindows-0.89pre8 on an Embedded Planet 823 platform.
> We were having trouble getting microwindows to run on the EP but in our
> trials we found a prototype in kdb_null.c which read:
>   static int  NUL_Read(MWUCHAR *buf, MWKEYMOD *modifiers, MWSCANCODE
> *scancode);
> when it should be:
>   static int  NUL_Read(MWKEY *buf, MWKEYMOD *modifiers, MWSCANCODE
> *scancode);
>
> After changing this the microwindows build went through properly. Should
> this be
> updated in the microwindows source?
>
> Regards,
>      Michael Pergola
>      Software Engineer
>      Danfoss Air-Conditioning & Refrigeration Division
>      7941 Corporate Blvd.
>      Baltimore, MD  21236     (410) 931-6778 x4259
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: ####@####.####
> For additional commands, e-mail: ####@####.####

Gladly, here it is:

--- kbd_null.c.old      Thu Jan 10 15:16:14 2002
+++ kbd_null.c.new      Thu Jan 10 15:29:48 2002
@@ -9,7 +9,7 @@
 static int  NUL_Open(KBDDEVICE *pkd);
 static void NUL_Close(void);
 static void NUL_GetModifierInfo(MWKEYMOD *modifiers, MWKEYMOD
*curmodifiers);
-static int  NUL_Read(MWUCHAR *buf, MWKEYMOD *modifiers, MWSCANCODE
*scancode);
+static int  NUL_Read(MWKEY *buf, MWKEYMOD *modifiers, MWSCANCODE
*scancode);
 static int  NUL_Poll(void);
 
 KBDDEVICE kbddev = {
@@ -65,7 +65,7 @@
  * This is a non-blocking call.
  */
 static int
-NUL_Read(MWUCHAR *buf, MWKEYMOD *modifiers, MWSCANCODE *scancode)
+NUL_Read(MWKEY *buf, MWKEYMOD *modifiers, MWSCANCODE *scancode)
 {
        return 0;
 }

And as an attachment:  <<kbd_null.patch>> 

Mike

> -----Original Message-----
> From:	Jordan Crouse ####@####.####
> Sent:	Thursday, January 10, 2002 10:26 AM
> To:	Pergola, Michael; ####@####.####
> Subject:	Re: [nanogui] null keyboard prototype error
> 
> > Should this be updated in the microwindows source?
> 
> Yep... :)
> 
> Could you send a quick patch and CC ####@####.####  
> 
> Jordan
> 
> On Thursday 10 January 2002 08:18, Pergola, Michael mentioned:
> > All,
> >
> > I am using microwindows-0.89pre8 on an Embedded Planet 823 platform.
> > We were having trouble getting microwindows to run on the EP but in our
> > trials we found a prototype in kdb_null.c which read:
> >   static int  NUL_Read(MWUCHAR *buf, MWKEYMOD *modifiers, MWSCANCODE
> > *scancode);
> > when it should be:
> >   static int  NUL_Read(MWKEY *buf, MWKEYMOD *modifiers, MWSCANCODE
> > *scancode);
> >
> > After changing this the microwindows build went through properly. Should
> > this be
> > updated in the microwindows source?
> >
> > Regards,
> >      Michael Pergola
> >      Software Engineer
> >      Danfoss Air-Conditioning & Refrigeration Division
> >      7941 Corporate Blvd.
> >      Baltimore, MD  21236     (410) 931-6778 x4259
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: ####@####.####
> > For additional commands, e-mail: ####@####.####

:   static int  NUL_Read(MWUCHAR *buf, MWKEYMOD *modifiers, MWSCANCODE
: *scancode);
: when it should be:
:   static int  NUL_Read(MWKEY *buf, MWKEYMOD *modifiers, MWSCANCODE
: *scancode);
: 
: After changing this the microwindows build went through properly.

Ah yes, the old (&char != &int) on big endian processors problem.

Thanks, I'll update the source tree.

Regards,

Greg