nanogui: About the fbportrait_down.c
Subject:
About the fbportrait_down.c
From:
"max xiayi" ####@####.####
Date:
8 Feb 2007 08:06:39 +0000
Message-Id: <afda14700702080006k3c301ccfq56376f5da40f2e46@mail.gmail.com>
Hi Greg,
I notice some bugs in fbportrait_down.c, but I am not very sure, just for
your information.
I write my idea in the comments like "//..............."
1.SUBDRIVER fbportrait_down = {
NULL,
fbportrait_drawpixel,
fbportrait_readpixel,
fbportrait_drawhorzline,
fbportrait_drawvertline,
gen_fillrect, //It should be fbportrait_fillrect, and
the same error happens in fbportrait_left.c, fbportrait_right.c
fbportrait_blit,
NULL,
fbportrait_stretchblit
};
2.fbportrait_fillrect(PSD psd,MWCOORD x1, MWCOORD y1, MWCOORD x2, MWCOORD
y2,
MWPIXELVAL c)
{
y2 = psd->yvirtres-y2-1;
y1 = psd->yvirtres-y1-1;
x1 = psd->xvirtres-x2-1; //It should be x1 = x1
x2 = psd->xvirtres-x1-1; //It should be x2 = x2
while(y2 <= y1)
psd->orgsubdriver->DrawHorzLine(psd, x2, x1, y2++, c);
}
Do you think my idea is right, grey?
Max
