nanogui: About the fbportrait_down.c
Subject:
Re: [nanogui] About the fbportrait_down.c
From:
"Greg Haerr" ####@####.####
Date:
12 Feb 2007 02:07:24 +0000
Message-Id: <072c01c74e4a$778d8be0$6401a8c0@winXP>
I don't think these are bugs... were you having a problem
with rectangle fills? By using the original gen_fillrect routine,
the rectangle fills are faster, since they are able to write
pixels in side-by-side, rather than line-by-line, as your
fix will require.
Regards,
Greg
: Hi Greg,
: I notice some bugs in fbportrait_down.c, but I am not very sure, just for
: your information.
: I write my idea in the comments like "//..............."
: 1.SUBDRIVER fbportrait_down = {
: NULL,
: fbportrait_drawpixel,
: fbportrait_readpixel,
: fbportrait_drawhorzline,
: fbportrait_drawvertline,
: gen_fillrect, //It should be fbportrait_fillrect,
and
: the same error happens in fbportrait_left.c, fbportrait_right.c
: fbportrait_blit,
: NULL,
: fbportrait_stretchblit
: };
:
: 2.fbportrait_fillrect(PSD psd,MWCOORD x1, MWCOORD y1, MWCOORD x2, MWCOORD
: y2,
: MWPIXELVAL c)
: {
: y2 = psd->yvirtres-y2-1;
: y1 = psd->yvirtres-y1-1;
: x1 = psd->xvirtres-x2-1; //It should be x1 = x1
: x2 = psd->xvirtres-x1-1; //It should be x2 = x2
: while(y2 <= y1)
: psd->orgsubdriver->DrawHorzLine(psd, x2, x1, y2++, c);
: }
: Do you think my idea is right, grey?
:
: Max
:
