nanogui: [PATCH] use diag_printf() for GdError() under eCos


Previous by date: 6 Oct 2005 02:34:59 +0100 Re: [PATCH] get rid of unused fontmapper variables, Greg Haerr
Next by date: 6 Oct 2005 02:34:59 +0100 nano-x on an old mac?, Yan Seiner
Previous in thread: 6 Oct 2005 02:34:59 +0100 [PATCH] use diag_printf() for GdError() under eCos, Alexander Neundorf
Next in thread: 6 Oct 2005 02:34:59 +0100 Re: [PATCH] use diag_printf() for GdError() under eCos, Alexander Neundorf

Subject: Re: [nanogui] [PATCH] use diag_printf() for GdError() under eCos
From: "Greg Haerr" ####@####.####
Date: 6 Oct 2005 02:34:59 +0100
Message-Id: <20c501c5ca15$323623a0$0300a8c0@RDP>

: the attached patch makes GdError() use the diag_printf() function under
eCos,
: which is already included in a very basic eCos configuration, while
write()
: requires much more packages to be included in eCos.

I would make a couple of changes:

1. add va_start() to the non-#ifdef code, thus only
requiring the single line difference diag_printf() to
replace write for eCos.

2. Use /* */ rather than // in any comments, in keeping
with the rest of the source.

Regards,

Greg


Previous by date: 6 Oct 2005 02:34:59 +0100 Re: [PATCH] get rid of unused fontmapper variables, Greg Haerr
Next by date: 6 Oct 2005 02:34:59 +0100 nano-x on an old mac?, Yan Seiner
Previous in thread: 6 Oct 2005 02:34:59 +0100 [PATCH] use diag_printf() for GdError() under eCos, Alexander Neundorf
Next in thread: 6 Oct 2005 02:34:59 +0100 Re: [PATCH] use diag_printf() for GdError() under eCos, Alexander Neundorf


Powered by ezmlm-browse 0.20.