nanogui: [PATCH] use diag_printf() for GdError() under eCos

Previous by date:	7 Oct 2005 17:22:28 +0100 Re: [PATCH] get rid of unused fontmapper variables, Alexander Neundorf
Next by date:	7 Oct 2005 17:22:28 +0100 Re: [PATCH] use diag_printf() for GdError() under eCos, Greg Haerr
Previous in thread:	7 Oct 2005 17:22:28 +0100 Re: [PATCH] use diag_printf() for GdError() under eCos, Greg Haerr
Next in thread:	7 Oct 2005 17:22:28 +0100 Re: [PATCH] use diag_printf() for GdError() under eCos, Greg Haerr

Subject: Re: [nanogui] [PATCH] use diag_printf() for GdError() under eCos
From: Alexander Neundorf ####@####.####
Date: 7 Oct 2005 17:22:28 +0100
Message-Id: <200510071806.04519.neundorf@kde.org>

Hi,

On Thursday 06 October 2005 03:28, Greg Haerr wrote:
...
> I would make a couple of changes:
>
> 1. add va_start() to the non-#ifdef code, thus only
> requiring the single line difference diag_printf() to
> replace write for eCos.

I considered this too, then it would look like the attached patch, i.e. with 
braces.

Do you like it better this way ?

Bye
Alex
-- 
Work: ####@####.#### - http://www.jenoptik-los.de
Home: ####@####.####                - http://www.kde.org
      ####@####.####               - http://www.neundorf.net

[Content type text/x-diff not shown. Download]

Previous by date:	7 Oct 2005 17:22:28 +0100 Re: [PATCH] get rid of unused fontmapper variables, Alexander Neundorf
Next by date:	7 Oct 2005 17:22:28 +0100 Re: [PATCH] use diag_printf() for GdError() under eCos, Greg Haerr
Previous in thread:	7 Oct 2005 17:22:28 +0100 Re: [PATCH] use diag_printf() for GdError() under eCos, Greg Haerr
Next in thread:	7 Oct 2005 17:22:28 +0100 Re: [PATCH] use diag_printf() for GdError() under eCos, Greg Haerr