nanogui: [PATCH] get rid of unused fontmapper variables
Subject:
Re: [nanogui] [PATCH] get rid of unused fontmapper variables
From:
"Greg Haerr" ####@####.####
Date:
7 Oct 2005 18:41:00 +0100
Message-Id: <235a01c5cb64$e01d6c80$6401a8c0@winXP>
: What is the fontmapper actually ? I thought it would be something "better"
: than eh, no fontmapper ?
Well... the fontmapper is a font selector that was contributed in the
very early days of microwindows' font development. I have to
admit I've never used it. Instead, when I added win32 API font
support, I was obligated to emulate that behaviour, for which
the MWLOGFONT (win32 LOGFONT) came about. This
additional "fuzzy spec" for fonts was then optionally included
in the GrCreateFont nano-X API. Fontmapper also has aliases,
which I suppose could be nice, but few use (since most applications
programs seem to want to read something more like X11's
definitions)
: Ah, right, this is an source- and binary incompatible change. For systems
like
: eCos and RTEMS, where no shared libraries exist, binary compatibility is
no
: issue, for other systems it is.
: I see the following options:
: 1) leave it as is
: 2) leave it as is and add a comment
: 3) apply my patch
: 4) only exclude the unused vars for ecos and rtems (are there more like
these
: two ?)
: 5) rename FONTMAPPER to ENABLE_COMPAT or something like this and exclude
the
: variables if ENABLE_COMPAT is not set
: 6) just remove the fontmapper code
Well done. If you are trying to remove these values to keep eCos small,
then I would suggest #3. However, I'm aware of very few static
MWLOGFONTs, most are stack-based so I don't see the savings.
I don't think we should break compatibility without good planning, so
otherwise I would suggest #2.
In the longer term, #6 should be investigated.
Regards,
Greg
