nanogui: [PATCH] get rid of unused fontmapper variables
Subject:
Re: [nanogui] [PATCH] get rid of unused fontmapper variables
From:
Alexander Neundorf ####@####.####
Date:
7 Oct 2005 17:15:12 +0100
Message-Id: <200510071814.03893.neundorf@kde.org>
Hi,
On Thursday 06 October 2005 03:25, you wrote:
> : the attached patch #ifdefs out the variables which are used only if
>
> FONTMAPPER
>
> : is defined.
> :
> : Ok to apply ?
>
> Yes, however this changes an idea I've had where (especially in
> the case of MWLOGFONT), compilation switches don't change
> structure members, thus requiring Microwindows to be built using
> certain #defines in the config file in order for an application to
> compile.
>
> Certainly FONTMAPPER doesn't seem to be used anymore, but,
What is the fontmapper actually ? I thought it would be something "better"
than eh, no fontmapper ?
> since MWLOGFONT values are purely suggestive, why make
> this change? Just to clean up? (at the expense of possibly breaking
> an application compile and changing internal structure sizes?)
Ah, right, this is an source- and binary incompatible change. For systems like
eCos and RTEMS, where no shared libraries exist, binary compatibility is no
issue, for other systems it is.
I see the following options:
1) leave it as is
2) leave it as is and add a comment
3) apply my patch
4) only exclude the unused vars for ecos and rtems (are there more like these
two ?)
5) rename FONTMAPPER to ENABLE_COMPAT or something like this and exclude the
variables if ENABLE_COMPAT is not set
6) just remove the fontmapper code
Bye
Alex
--
Work: ####@####.#### - http://www.jenoptik-los.de
Home: ####@####.#### - http://www.kde.org
####@####.#### - http://www.neundorf.net
